Remove deprecated parts of OMCPath#346
Draft
syntron wants to merge 5 commits intoOpenModelica:masterfrom
Draft
Conversation
Contributor
Author
|
@adeas31 could you please set milestone 5.0.0 for this PR? If Python < 3.12 is still supported at that time, it could be moved to a later point; however, I think it is important to keep this PR in sight / stay aware of it |
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
from
f1e63bd to
17a3fdc
Compare
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
from
17a3fdc to
21a531b
Compare
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
from
21a531b to
5387ff1
Compare
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
from
5387ff1 to
75ded21
Compare
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
2 times, most recently
from
8b03249 to
0fdc267
Compare
Member
|
Rebase |
* ensure a message if logged if returncode != 0
* self.session().run_model_executable() will raise OMCSessionException!
syntron
force-pushed
the
remove_deprecated-OMCPath
branch
from
0fdc267 to
dc6dd5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes the compatibility layer for PR #314 (OMCPath); this can be applied as soon as OMPython suports only Python >= 3.12 (version/ milestone 5.0.0?)